espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.71k stars 7.43k forks source link

feat(zigbee): Add setLight APIs to manually operate lights #10626

Closed P-R-O-C-H-Y closed 2 days ago

P-R-O-C-H-Y commented 2 days ago

Description of Change

This PR adds APIs to the light endpoints to enable controlling them by itself. The status of the Light is updated in the clusters, so the actual state is updated in the Smart home apps.

Tests scenarios

Tested locally with HomeAssistant.

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

github-actions[bot] commented 2 days ago
Warnings
:warning: The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

πŸ‘‹ Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 3be6664c0b6d68bc9a7c35307cc26ac76c8e159d

github-actions[bot] commented 2 days ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6:green_heart: -251:bangbang: +13K:green_heart: -0.05:bangbang: +2.700:warning: +16640.00:bangbang: +5.60
ESP32H2:green_heart: -4K:bangbang: +9K:green_heart: -0.69:bangbang: +1.830:warning: +15720.00:bangbang: +5.42
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light:bangbang: +3K:warning: +1664:warning: +503:warning: +1572
Zigbee/examples/Zigbee_Color_Dimmer_Switch:bangbang: +9K:warning: +936:bangbang: +6K:warning: +844
Zigbee/examples/Zigbee_On_Off_Light:bangbang: +3K:warning: +1664:green_heart: -255:warning: +1572
Zigbee/examples/Zigbee_On_Off_Switch:bangbang: +9K:warning: +920:bangbang: +6K:warning: +844
Zigbee/examples/Zigbee_Scan_Networks:bangbang: +13K:warning: +1236:bangbang: +9K:warning: +1112
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy:green_heart: -251:warning: +964:green_heart: -4K:warning: +832
Zigbee/examples/Zigbee_Temperature_Sensor:bangbang: +11K:warning: +944:bangbang: +7K:warning: +836
Zigbee/examples/Zigbee_Thermostat:bangbang: +11K:warning: +608:bangbang: +8K:warning: +540
github-actions[bot] commented 2 days ago

Test Results

 62 files   62 suites   7m 46s ⏱️  22 tests  21 βœ…β€ƒ0 πŸ’€β€ƒ1 ❌ 144 runsβ€Šβ€ƒ143 βœ…β€ƒ0 πŸ’€β€ƒ1 ❌

For more details on these failures, see this check.

Results for commit cdc1a420.