espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.71k stars 7.43k forks source link

OTA Library adjust #10627

Closed SuGlider closed 2 days ago

SuGlider commented 2 days ago

Description of Change

General revision of OTA Arduino Library.

Tests scenarios

Example using ESP32, ESP32-S3 Testing using CI

Related links

None

github-actions[bot] commented 2 days ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"feat(ota): library revision"`: - *summary* looks too short - the commit message `"feat(ota): license addtion"`: - *summary* looks too short - the commit message `"feat(ota): license"`: - *summary* looks too short *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
Messages
:book: You might consider squashing your 4 commits (simplifying branch history).

πŸ‘‹ Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (πŸ“–) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 4699b02e88fd639065d07dd9ee3971cc4a484d3a

github-actions[bot] commented 2 days ago

Test Results

 56 files   56 suites   4m 18s ⏱️  21 tests  21 βœ…β€ƒ0 πŸ’€β€ƒ0 ❌ 134 runsβ€Šβ€ƒ134 βœ…β€ƒ0 πŸ’€β€ƒ0 ❌

Results for commit 4699b02e.

:recycle: This comment has been updated with latest results.

SuGlider commented 2 days ago

@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find esp_zigbee_core.h in the arduino libs.

https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627 https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627

$ find . -name esp_zigbee_core.h -print 2> /dev/null
./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
lucasssvaz commented 2 days ago

@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find esp_zigbee_core.h in the arduino libs.

https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627 https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627

$ find . -name esp_zigbee_core.h -print 2> /dev/null
./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h

Master branch has out of date libs that does not include zigbee. Just ignore this