Closed SuGlider closed 2 days ago
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"feat(ota): library revision"`:
- *summary* looks too short
- the commit message `"feat(ota): license addtion"`:
- *summary* looks too short
- the commit message `"feat(ota): license"`:
- *summary* looks too short
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
Messages | |
---|---|
:book: | You might consider squashing your 4 commits (simplifying branch history). |
π Hello SuGlider, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (β οΈ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (π) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 4699b02e88fd639065d07dd9ee3971cc4a484d3a
β56 filesβββ56 suitesβββ4m 18s β±οΈ β21 testsββ21 β β0 π€β0 β 134 runsββ134 β β0 π€β0 β
Results for commit 4699b02e.
:recycle: This comment has been updated with latest results.
@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find esp_zigbee_core.h
in the arduino libs.
https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627 https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627
$ find . -name esp_zigbee_core.h -print 2> /dev/null
./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find
esp_zigbee_core.h
in the arduino libs.https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627 https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627
$ find . -name esp_zigbee_core.h -print 2> /dev/null ./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h ./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h ./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h ./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h ./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h ./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
Master branch has out of date libs that does not include zigbee. Just ignore this
Description of Change
General revision of OTA Arduino Library.
Tests scenarios
Example using ESP32, ESP32-S3 Testing using CI
Related links
None