search

espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.71k stars 7.43k forks source link

Guard crypto parts in "Update" to save resources #10629

Closed Jason2866 closed 2 days ago

Jason2866 commented 2 days ago

This PR guards the crypto parts in library Update. By doing this flash space is saved, since most users don't use crypto updates. To enable the possibility of crypto updates again just adding #define UPDATE_CRYPT to the sketch to enable the functionality again. (similar to #9893)

github-actions[bot] commented 2 days ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"Add P4 to chip info"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Add RMII Ethernet support for ESP32-P4 (#10479)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Add support for WiFi to ESP32-P4 (#10463)"`: - body's lines must not be longer than 100 characters - *summary* looks empty - *type/action* looks empty - the commit message `"ESP32-P4 UART Pin Definitions (#10521)"`: - body's lines must not be longer than 100 characters - *summary* looks empty - *type/action* looks empty - the commit message `"Enable tests for ESP32P4"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Fix build of camera web server"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Fix ethernet examples JSON for P4"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Fix formatting in ETH and USB"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Fix partitions for examples"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Fix touch examples JSON for P4"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Guard WPA Enterprise support (#10616)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Guard ethernet parts to make it possible to use without (#10609)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10272)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10403)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10444)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10465)"`: - footer's lines must not be longer than 100 characters - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10503)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 (#10599)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 0bbd7281 (#10258)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 59550599 (#10498)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 707d097b (#10416)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 707d097b (#10473)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 707d097b (#10480)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"IDF release/v5.3 a0f798cf (#10522)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Matter example patch (#10618)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update MatterOnOffLight.ino"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update TinyUSB init method"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update Updater.cpp"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update core version to 3.1.0"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update early system init function declaration"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update esp-insights version (#10456)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update package_esp32_index.template.json"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update readme"`: - *summary* looks empty - *type/action* looks empty - the commit message `"add(build): Add initial ESP32-P4 skeleton"`: - *type/action* should be one of [`change`, `ci`, `docs`, `feat`, `fix`, `refactor`, `remove`, `revert`, `test`] - the commit message `"feat(Matter): New Matter Endpoint - Dimmable Light (#10543)"`: - *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.` - the commit message `"feature(rtos): Add Tasks status print function (#10515)"`: - *type/action* should be one of [`change`, `ci`, `docs`, `feat`, `fix`, `refactor`, `remove`, `revert`, `test`] - the commit message `"fix weird formatting, no code change (#10617)"`: - *summary* looks empty - *type/action* looks empty - the commit message `"fix(IPaddress): IPv6 restore zone id (#10546)"`: - body's lines must not be longer than 100 characters - *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.` - the commit message `"fix(Zigbee): Add missing direction to report commands (#10623)"`: - *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.` - the commit message `"fix(bm): Board Manager install will fail on Windows (#10533)"`: - body's lines must not be longer than 100 characters - the commit message `"fix(build): Fix many warnings"`: - *summary* looks too short - the commit message `"fix(build): Fix warning in FFat"`: - *summary* looks too short - the commit message `"fix(eth): Set default clock in pin value to zero (#10513)"`: - body's lines must not be longer than 100 characters - the commit message `"fix(p4): Move ESP-HOSTED init to WiFiGeneric"`: - body's lines must not be longer than 100 characters - the commit message `"fix(spiram): Fix OPI PSRAM init"`: - *summary* looks too short - the commit message `"guard crypt update"`: - *summary* looks empty - *type/action* looks empty - the commit message `"guard update crypt"`: - *summary* looks empty - *type/action* looks empty - the commit message `"replace outdated wrong `SOC_I2C_NUM` and use `SOC_HP_I2C_NUM` (#10452)"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
:warning: Please consider squashing your 119 commits (simplifying branch history).
Messages
:book: This PR seems to be quite large (total lines of code: 5943), you might consider splitting it into smaller PRs

👋 Hello Jason2866, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against f92abd18b1b01e5ab291611110ff19b378e6f6d6