search

espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.73k stars 7.43k forks source link

Add support for Waveshare ESP32-S3-Tiny base on ESP32-S3FH4R2 chip (Closes #10633) #10634

Open Godeffroy opened 4 days ago

Godeffroy commented 4 days ago

Checklist

  1. [x] Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. [x] Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. [x] Please update relevant Documentation if applicable
  4. [x] Please check Contributing guide
  5. [x] Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Add pin definition of the Waveshare board ESP32-S3-Tiny

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v2.0.17 based on ESP-IDF 4.4.7 with ESP32-S3-Tiny Board with this scenario with PlatformIO on VsCode

Related links

Closes #10633 Adding Support in PlatformIO for Waveshare ESP32-S3-Tiny board

CLAassistant commented 4 days ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 4 days ago
Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello Godeffroy, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against dab7469e8cad57a4719a8f9279495a74d122128e

Jason2866 commented 4 days ago

The changes are not complete. Adding in boards.txt are missing An example https://github.com/espressif/arduino-esp32/pull/10549/files