EEPROM does not compile on the Arduino IDE 1.8.5

dirkx commented 6 years ago

Below patch is needed in order to get the EEPROM code to compile on recent SDKs.

Otherwise it moans/misses the call by reference populating the value and hence errors-out on the seemingly uninitialized value passed to readAll().

Dw.

commit 9889158c741360e86618a5a16e2fff2c876ae16e Author: Dirk-Willem van Gulik dirkx@webweaving.org Date: Mon Mar 19 17:59:01 2018 +0100

Quell compiler warnings in Arduino IDE 1.8.5

diff --git a/libraries/EEPROM/EEPROM.cpp b/libraries/EEPROM/EEPROM.cpp index 62e15af..d0ab410 100644 --- a/libraries/EEPROM/EEPROM.cpp +++ b/libraries/EEPROM/EEPROM.cpp @@ -178,85 +178,85 @@ uint16_t EEPROMClass::length () */ uint8_t EEPROMClass::readByte (int address) {

uint8_t value;
uint8_t value = 0; return EEPROMClass::readAll (address, value); }

int8_t EEPROMClass::readChar (int address) {
int8_t value;
int8_t value = 0; return EEPROMClass::readAll (address, value); }

uint8_t EEPROMClass::readUChar (int address) {
uint8_t value;
uint8_t value = 0; return EEPROMClass::readAll (address, value); }

int16_t EEPROMClass::readShort (int address) {
int16_t value;
int16_t value = 0; return EEPROMClass::readAll (address, value); }

uint16_t EEPROMClass::readUShort (int address) {
uint16_t value;
uint16_t value = 0; return EEPROMClass::readAll (address, value); }

int32_t EEPROMClass::readInt (int address) {
int32_t value;
int32_t value = 0; return EEPROMClass::readAll (address, value); }

uint32_t EEPROMClass::readUInt (int address) {
uint32_t value;
uint32_t value = 0; return EEPROMClass::readAll (address, value); }

int32_t EEPROMClass::readLong (int address) {
int32_t value;
int32_t value = 0; return EEPROMClass::readAll (address, value); }

uint32_t EEPROMClass::readULong (int address) {
uint32_t value;
uint32_t value = 0; return EEPROMClass::readAll (address, value); }

int64_t EEPROMClass::readLong64 (int address) {
int64_t value;
int64_t value = 0; return EEPROMClass::readAll (address, value); }

uint64_t EEPROMClass::readULong64 (int address) {
uint64_t value;
uint64_t value = 0; return EEPROMClass::readAll (address, value); }

float_t EEPROMClass::readFloat (int address) {
float_t value;
float_t value = 0; return EEPROMClass::readAll (address, value); }

double_t EEPROMClass::readDouble (int address) {
double_t value;
double_t value = 0; return EEPROMClass::readAll (address, value); }

bool EEPROMClass::readBool (int address) {
int8_t value;
int8_t value = false; return EEPROMClass::readAll (address, value) ? 1 : 0; }

bulentperktas commented 6 years ago

is this patch where it will be used?

i got the following errors while compiling in Arduino IDE 1.8.5

Thx,

`C:\Users\Arduino\hardware\espressif\esp32\libraries\EEPROM\EEPROM.cpp: In member function 'int8_t EEPROMClass::readChar(int)':

C:\Users\Arduino\hardware\espressif\esp32\libraries\EEPROM\EEPROM.cpp:188:46: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]

return EEPROMClass::readAll (address, value);

C:\Users\Arduino\hardware\espressif\esp32\libraries\EEPROM\EEPROM.cpp: In member function 'uint8_t EEPROMClass::readUChar(int)':

C:\Users\Arduino\hardware\espressif\esp32\libraries\EEPROM\EEPROM.cpp:194:46: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]

return EEPROMClass::readAll (address, value);

C:\Users\Arduino\hardware\espressif\esp32\libraries\EEPROM\EEPROM.cpp: In member function 'int16_t EEPROMClass::readShort(int)':