Closed insunaa closed 7 months ago
For what is this file there in general?
I have absolutely no idea, but it's there in the reference Arduino API, too. Tho they use namespaces and enums appropriately: https://github.com/arduino/ArduinoCore-API/blob/master/api/Binary.h
Why not open a PR and replace the current with the one you linked?
Because I don't know if it will break things. I don't usually develop for Arduino.
It doesn't break things in my own project, because in my own project I can just delete the
#include "binary.h"
line from Arduino.h
and everything works fine, but I have no idea what the impact would be on projects that actually use these
There is a reference from Arduino. This is an Arduino implementation. So the change is getting closer to the API :-) And this will go in v3.0.0 which has many breaking changes...
Board
LilyGo TTGO LoRa32
Device Description
Just a TTGO
Hardware Configuration
Not relevant
Version
latest master (checkout manually)
IDE Name
PlatformIO
Operating System
Linux
Flash frequency
not relevant
PSRAM enabled
yes
Upload speed
not relevant
Description
In
cores/esp32/binary.h
Causes compilation issues when Arduino.h is included in any project where the literal
B1
already means something.With newer versions of fmtlib/fmt
problems are also caused by
Example: using&including fmtlib/fmt where it's used as a template typename
Sketch
Debug Message
Other Steps to Reproduce
Could this be handled by an enum instead?
I have checked existing issues, online documentation and the Troubleshooting Guide