espressif / clang-tidy-runner

MIT License
9 stars 5 forks source link

feat: Drop support for ESP-IDF 4.4 and Python 3.6 #49

Closed peterdragun closed 1 month ago

peterdragun commented 1 month ago

Description

This MR includes several fixes for the pipeline to pass:

Reasons to drop ESP-IDF 4.4

TLDR: dependency hell

I was trying to make the pipeline work on the latest IDF, but there was a conflict with the pygments package because IDF required >=3.13. The requirement is coming from the codereport package, so I fixed that upstream and wanted to update the version here to match at least that version (codereport>=0.4.0). Then I realized that we are still stuck with codereport version 0.2.5, because of Jinja2. The newest versions of codereport (3.1+) require Jinja2==3.1.1, but ESP-IDF has this requirement set to <3.1, so there was no way to satisfy both ESP-IDF 4.4 and the latest versions.

Considering that ESP-IDF 4.4 is not supported anymore, this is IMO the best solution.

This is now working in the CI with IDF 5.0+, but if we hit some dependency issue again we should remove the dependency on the codereport package, there is not a lot of code, mostly just templates for HTML, so we should consider implementing this ourselves.

Related

Internal tracker: IDF-10919

peterdragun commented 1 month ago

@dobairoland PTAL, this should be ready to merge.