search

espressif / developer-portal

Developer Portal
https://developer.espressif.com
MIT License
7 stars 14 forks source link

fix: implement feedback to espresso article #56

Closed f-hollow closed 2 months ago

f-hollow commented 2 months ago

This MR implements feedback from Raffael Rostagno.

@raffarost Feel free to have another look.

raffarost commented 2 months ago

I still don't see the updated image in the article, but that was the only fix needed. Thank you

f-hollow commented 2 months ago

I still don't see the updated image in the article, but that was the only fix needed. Thank you

@raffarost I updated the image. You might not be able to see it because of local cache. I also used this chance and made some other improvements to improve the readability.

I will merge this PR and let's make sure that the image is updated.

f-hollow commented 2 months ago

Merged the MR and found that my browser still shows the old picture. Apparently, the issue is that I updated the picture but left the file name the same.

Then I found many similar thread like this. Aftetr clearing the browser cache, I see the updated picture.

From now on, I will always be changing file names of updated images.