espressif / esp-adf

Espressif Audio Development Framework
Other
1.55k stars 685 forks source link

how audio-recorder link esp-timer when idf-version < 5.0 (AUD-4602) #998

Closed IamFive closed 1 year ago

IamFive commented 1 year ago

audio-recorder component only requires esp-timer when idf-version >= 5.0. but why the code uses esp-timer directly, how it links when compile.

https://github.com/espressif/esp-adf/blob/a74a26f1f2c2f84a7c3631bdd34d365a26704fcc/components/audio_recorder/CMakeLists.txt#L14-L16

Environment

Problem Description

// Detailed problem description goes here.

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. step1
  2. ...

// If possible, attach a picture of your setup/wiring here.

Code to Reproduce This Issue

// the code should be wrapped in the ```cpp tag so that it will be displayed better.
#include "esp_log.h"

void app_main()
{

}

// If your code is longer than 30 lines, GIST is preferred.

Debug Logs

Debug log goes here. It should contain the backtrace, as well as the reset source if it is a crash.
Please copy the plaintext here for us to search the error log. Or attach the complete logs and leave the main part here if the log is *too* long.

Other Items If Possible

JosephTang commented 1 year ago

dear @IamFive , before idf v5.0, esp_timer is automatic added to the components requirements, so there is no need to append to COMPONENT_REQUIRES list. Compile can be sucess when build with IDF v4.4

IamFive commented 1 year ago

thank you.