espressif / esp-adf

Espressif Audio Development Framework
Other
1.55k stars 685 forks source link

afe_perferred typo in esp_afe_config.h and algorithm_stream.c (AUD-4603) #999

Closed Gaai closed 1 year ago

Gaai commented 1 year ago

Declared in esp_afe_config.h

typedef struct {
...<cut>
    int afe_perferred_core;
    int afe_perferred_priority;
...<cut>
} afe_config_t;

and used in algorithm_stream.c:

    afe_config.afe_perferred_core = 1;
    afe_config.afe_perferred_priority = 21;

Solution: Replace "perferred" with "preferred"

If that's all the references to this variable I can do a pull request.

Gaai commented 1 year ago

Another mistake, this time in audio_element.c: line 1297

    if (index >= el->multi_in.max_rb_num) {
        ESP_LOGE(TAG, "The index of ringbuffer is **gather than and equal to** ringbuffer maximum (%d). line %d", el->multi_in.max_rb_num, __LINE__);
        return ESP_FAIL;
    }

See: (...) gather than and equal to (...) That should be: `(...) greater than or equal to ringbuffer maximum (...)

jason-mao commented 1 year ago

@Gaai Thank you for your report. We will fix that.

feizi commented 1 year ago

Replace "perferred" with "preferred"

Thanks, I will fix it.

jason-mao commented 1 year ago

This topic will be fixed on ESP-SR repo.