search

espressif / esp-aws-iot

AWS IoT SDK for ESP32 based chipsets
Apache License 2.0
256 stars 154 forks source link

Add C++ protection header/footer (CA-247) #144

Closed NathanJPhillips closed 1 year ago

NathanJPhillips commented 1 year ago

This bumps two submodules to v1.2, which includes C++ protection headers/footers, and adds them to network_transport.h, copying the style from the upstream submodules.

avsheth commented 1 year ago

Hi @NathanJPhillips Thanks for fixing it. Couple of things though:

  1. Can you please rebase to latest master since master has been updated to point to latest LTS libraries, which includes changes in backoff_algorithm and coreMQTT the MR is trying to bring in.
  2. Would it be possible to make similar changes in below includes as well, so that MR can be merged as is: i. coreHTTP/port/network_transport/network_transport.h ii. coreMQTT-Agent/port/freertos_agent_message.h iii. coreMQTT-Agent/port/freertos_command_pool.h iv. corePKCS11/port/iot_crypto.h v. ota-for-aws-iot-embedded-sdk/port/ota_pal.h vi. ota-for-aws-iot-embedded-sdk/port/ota_os_freertos.h
shahpiyushv commented 1 year ago

Merged in commit https://github.com/espressif/esp-aws-iot/commit/88c09a4313aedd1e67b63cd38d08bc065cc27d9d