espressif / esp-azure

SDK to connect ESP8266 and ESP32 to Microsoft Azure IoT services
176 stars 92 forks source link

Dependency on main prevents use from other components (CA-124) #115

Open NathanJPhillips opened 3 years ago

NathanJPhillips commented 3 years ago

Referencing main from CMakeLists.txt creates a circular dependency that will in many cases cause undefined references during linking when esp-azure is REQUIREd by a component that is in turn REQUIREd by the main project.

Is this a known issue, are there reasons main needs to be referenced, or should I create a PR to remove this?

liudr commented 3 years ago

I'm curious, what is the reason that main is required in your CMakeLists.txt? I'm learning the CMake build system. This might help me understand what I don't know that I don't know. ;)

jspngh commented 3 years ago

I ran into the circular dependency issue as well after restructuring some code. I also don't see a reason for the dependency on main, so it would be good if someone from Espressif can comment whether it can be removed or not.