espressif / esp-bsp

Board support components for Espressif development boards

Other

142 stars 76 forks source link

Bsp/default lvgl version + runtime buffer size set #293

Closed espzav closed 3 months ago

espzav commented 3 months ago

ESP-BSP Pull Request checklist

[x] Version of modified component bumped
[x] CI passing

Change description

Set default LVGL version in all BSPs to LVGL8
Support setting display buffer size and other display settings from runtime initialization in BSP

espzav commented 3 months ago

Support setting display buffer size and other display settings from runtime initialization in BSP

@tore-espressif I made proposal in ESP-BOX, if it will be ok, I will copy to all BSPs - PTAL

tore-espressif commented 3 months ago

@espzav The proposal LGTM. Do you want add this change for all BSPs in this PR?

espzav commented 3 months ago

@espzav The proposal LGTM. Do you want add this change for all BSPs in this PR?

Yes, I will do same changes in all BSPs in this PR. Should I allow to make change from Kconfig in all boards too, or only runtime? I leave here, because backward compatibility, but it is not supported in all boards now.

tore-espressif commented 3 months ago

Should I allow to make change from Kconfig in all boards too, or only runtime

Let's add only runtime confiugration for the rest of the boards. Setting the same option in 2 place would be confusing. We can leave it as is for esp-box so we don't break compatibility

espzav commented 3 months ago

@tore-espressif PTAL