espressif / esp-bsp

Board support components for Espressif development boards
Other
141 stars 76 forks source link

PRIV_REQUIRES onewire_bus (BSP-481) #316

Open morgana2313 opened 1 month ago

morgana2313 commented 1 month ago

Using ds18b20 gives an error:

components/espressif__ds18b20/src/ds18b20.c:10:10: fatal error: onewire_bus.h: No such file or directory
   10 | #include "onewire_bus.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
[...]
BUG: onewire_bus.h found in component espressif__onewire_bus which is already in the requirements list of espressif__ds18b20

Fix: components/ds18b20/CMakeLists.txt

idf_component_register(SRCS "src/ds18b20.c"
                       INCLUDE_DIRS "include"
+                        PRIV_REQUIRES onewire_bus
)
suda-morris commented 1 month ago

Hi @morgana2313 May I know how you use the onewire_bus and the ds18b20 components? Are you using them with component manager? In the manifest file, we have declared the dependency on the onewire_bus.