espressif / esp-bsp

Board support components for Espressif development boards
Other
141 stars 76 forks source link

"#include "esp_idf_version.h" missing in lvgl9 version of file "esp_lvgl_port_disp.c" (BSP-486) #321

Closed MikeOchtman closed 6 days ago

MikeOchtman commented 3 weeks ago

Board

ESP32S3

Hardware Description

FREENOVE ESP32-S3 WROOM

IDE Name

VSCode

Operating System

Windows 10

Description

The macro ESP_IDF_VERSION_VAL is not defined in file "managed_components\espressif__esp_lvgl_port\src\lvgl9\esp_lvgl_port_disp.c" because "esp_idf_version.h" is not #included in any of the headers or source files in the compilation unit.

It also cannot be included by user without breaking the managed component relationship.

Sketch

/* the file includes the macro in the first and subsequent 'if' statements as below */
#include "esp_log.h"
#include "esp_err.h"
#include "esp_check.h"
#include "esp_heap_caps.h"
#include "esp_lcd_panel_io.h"
#include "esp_lcd_panel_ops.h"
#include "esp_lvgl_port.h"

#if (CONFIG_IDF_TARGET_ESP32P4 && ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0))
{
}

Other Steps to Reproduce

No response

I have checked existing issues, README.md and ESP32 Forum

espzav commented 3 weeks ago

Hi @MikeOchtman, This PR is solving this issue: https://github.com/espressif/esp-bsp/pull/320