espressif / esp-bsp

Board support components for Espressif development boards

Other

141 stars 76 forks source link

feat(LVGL port): Support for RGB screen #322

Open espzav opened 3 weeks ago

espzav commented 3 weeks ago

ESP-BSP Pull Request checklist

[x] Waiting for merge #320
[x] Version of modified component bumped
[x] CI passing

Change description

1: esp_lv_port adds RGB interface support

All BSPs will be updated in next PR.

Many thanks to @espressif2022 for very well support! This PR is made from #313

espzav commented 3 weeks ago

One issue is here. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line: https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L230 and this line https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L216 I am working on it. I don't know, how to handle right, for maximum task sleep.

espzav commented 3 weeks ago

@tore-espressif PTAL

espzav commented 6 days ago

One issue is here. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line:

https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L230

and this line https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L216

I am working on it. I don't know, how to handle right, for maximum task sleep.

Fixed on master.

espzav commented 6 days ago

@espressif2022 and @tore-espressif Do we want to update BSP for esp32_s3_lcd_ev_board in this PR or should we make new PR (or update #313)?

espressif2022 commented 6 days ago

@espressif2022 and @tore-espressif Do we want to update BSP for esp32_s3_lcd_ev_board in this PR or should we make new PR (or update #313)?

There is an RGB example in the test case. I think this PR does not need to be updated BSP of esp32_s3_lcd_ev_board.

espzav commented 14 hours ago

@tore-espressif Thank you for the first round of the review. I fixed all issues. You can continue.