search

espressif / esp-bsp

Board support components for Espressif development boards
Other
194 stars 102 forks source link

Updating/Replacing the existing MPU6050 driver (BSP-567) #415

Open jeetrohan opened 3 days ago

jeetrohan commented 3 days ago

Related area

esp-bsp/components/mpu6050

Hardware specification

None

Is your feature request related to a problem?

Current driver for mpu6050 uses legacy i2c driver. Which makes it inoperable with other recent components.

Describe the solution you'd like

I've written and tested a new driver for mpu6050 using the current i2c driver framework. Further I've added the functionality to use the in-built motion detection feature of mpu6050. I'm planning to update it and add more features. Is it possible to update/replace the current driver with my contribution?

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

tore-espressif commented 3 days ago

Hello @jeetrohan thank you for your interest. Yes, we want to update mpu6050 to the new I2C driver. If you already have it, you can open a PR to this repository and we can help review, thanks!

jeetrohan commented 2 days ago

Hello @jeetrohan thank you for your interest. Yes, we want to update mpu6050 to the new I2C driver. If you already have it, you can open a PR to this repository and we can help review, thanks!

Hi @tore-espressif thanks for guidance. I'm very new to using Github so there maybe issues with my PR (used GIthub this week for the first time, just to make this contribution).

I have simply forked the esp-bsp repo, branched it and created my files in the branch and made a PR. Please let me know if I've done it right or do I need to redo it in some other way.

jeetrohan commented 2 days ago

this previous close was a mistake at my end.