Variable name confusion in csi_data_read_parse.py file (AEGHB-723)

espressif / esp-csi

Applications based on Wi-Fi CSI (Channel state information), such as indoor positioning, human detection

Apache License 2.0

671 stars 104 forks source link

Variable name confusion in csi_data_read_parse.py file (AEGHB-723) #187

Closed TryTwoTop closed 3 weeks ago

TryTwoTop commented 2 months ago

File path: esp-csi / examples / get-started / tools / csi_data_read_parse.py

Is it correct to change from phase to amplitude in the variable name self.csi_phase_array?

*Link https://github.com/espressif/esp-csi/blob/master/examples/get-started/tools/csi_data_read_parse.py#L85

suhipek commented 1 month ago

I think you're correct. Indeed the result of np.abs(csi_data_array) should be its amplitudes. We will fix this typo in upcoming updates. Thank you for reporting it!