dot product example doesn't really compute n!

espressif / esp-dsp

DSP library for ESP-IDF

Apache License 2.0

465 stars 87 forks source link

dot product example doesn't really compute n! #1

Closed aguaviva closed 5 years ago

aguaviva commented 5 years ago

The dot product in the esp-dsp/examples/dotprod/main/dsps_dotproduct_main.c file won't compute n! as the comment says, it will just compute the addition of all numbers from 0 to 255.

dmitry1945 commented 5 years ago

Sure! It compute sum!

igrr commented 5 years ago

Fixed in https://github.com/espressif/esp-dsp/commit/2a490f4908102b0809fe95e56551826599365936.

aguaviva commented 5 years ago

great! And sorry for being so picky :)