search

espressif / esp-dsp

DSP library for ESP-IDF
Apache License 2.0
465 stars 87 forks source link

Fix matrix subtraction bug #34

Closed chibi314 closed 2 years ago

chibi314 commented 2 years ago

I made this PR to fix the problem mentioned in #33 .

In addition, I modified the test code about subtraction. The unit tests passes now.

chibi314 commented 2 years ago

Can any maintainers merge this PR?

dmitry1945 commented 2 years ago

Hi @chibi314 , It was a maintenance on our environments. Will do this today.

Thanks.

dmitry1945 commented 2 years ago

@chibi314 could you please update your repo with espressif:master, and rebase your PR to the latest master? I will take your commits and then just push them to our master, then they will be pushed to the github, and PR will be closed automatically. If I will take commits now and will rebase, then PR will be shown as open.

chibi314 commented 2 years ago

@dmitry1945 Thanks. I updated my master and rebased fix_matrix_subtraction branch. Is this OK now?

dmitry1945 commented 2 years ago

@chibi314 yes,

will merge it with master today/tomorrow. Thank you!