search

espressif / esp-eth-drivers

Collection of additional Ethernet drivers for ESP-IDF
24 stars 16 forks source link

Version release? (IDFGH-8225) #2

Closed stkw0 closed 2 years ago

stkw0 commented 2 years ago

I saw that there is a version release on idf component registry website but I don't see any tag on this repository. I think it will be nice to have a tag or a way to correlate which version corresponds to which commit.

Thank you

kostaond commented 2 years ago

Hi @stkw0, good catch! I will add label.

kostaond commented 2 years ago

I discussed the issue with my colleague and he had a good point: if we had multiple devices supported (which we want in the future), each would have its idf_component.yml with its specific version but the tag applies to the whole repo. Therefore it is probably not possible to do so and I will close the issue. @stkw0, do you agree?

stkw0 commented 2 years ago

I see, so I should try to use idf component manager instead of just adding this repository as a submodule as I'm currently doing, right?

kostaond commented 2 years ago

Yes, you are right. If you want to use it as is, you should use component manager. If you are planning to contribute or perform some tweaks, you need to use it as submodule.

stkw0 commented 2 years ago

okay. I will close the issue then

igrr commented 2 years ago

If you are planning to contribute or perform some tweaks, you need to use it as submodule.

Note that the IDF component manager still allows adding components from Git repositories, so it should work even if you need to fork the project at some point.

  ksz8863:
    git: https://github.com/your-fork/esp-eth-drivers.git
    path: ksz8863    # path inside the repository
    version: c469b510f71a46bcc993421f12e69472a5fcbe9a    # 40-character Git commit ID