search

espressif / esp-homekit-sdk

550 stars 99 forks source link

Memory leak in hap_send_notification #6

Closed MacWyznawca closed 3 years ago

MacWyznawca commented 3 years ago

Memory leak in hap_send_notification (hap_char_update_val)

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

shahpiyushv commented 3 years ago

@MacWyznawca , thanks for this fix. I have left a minor comment. Once that is resolved, we can merge this.

shahpiyushv commented 3 years ago

@MacWyznawca , can you make a couple of minor changes?

  1. Squash the 2 commits into one
  2. Slightly Rephrase commit message
Bugfix: Memory leak in hap_send_notification

Fixed a memory leak in hap_send_notification (hap_char_update_val)

Normally we import the PR into our internal repo, merge it and then push to GitHub. I could have made these changes myself, but then that would generate a new commit id and not reflect cleanly against this PR :)

MacWyznawca commented 3 years ago

Thanks @shahpiyushv ! I think it will be faster if they did it themselves. After this patch, my accessories are working for 10 days without any error or reboot;) Before, after 15-40 minutes I was running out of RAM.

shahpiyushv commented 3 years ago

Merged in this commit. Thank you for the contribution @MacWyznawca .