search

espressif / esp-homekit-sdk

562 stars 105 forks source link

Fix "Filter Life Level" constraints #7

Closed Cosmo closed 3 years ago

Cosmo commented 3 years ago

Took me a while to understand the whole SDK :)

According to Apple's "HomeKit Accessory Protocol Specification", the "Filter Life Level" characteristic expects the value type of float. While hap_char_filter_life_level_create(float filter_life_level) in the esp-homekit-sdk expects a float as input, the constraints are set to integers.

This renders the service and accessory as incompatible to HomeKit.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

shahpiyushv commented 3 years ago

@Cosmo Thanks for debugging and fixing this. The PR has now been merged.