espressif / esp-homekit-sdk

541 stars 98 forks source link

Sprinkler, Faucet, Shower CIDs #98

Closed jimmyasyraf closed 1 year ago

jimmyasyraf commented 1 year ago

Why? I'm working on a project to automate watering my plants and I realized the CID for Sprinkler is missing. A couple others like Faucet and Shower are missing as well as this ticket (https://github.com/espressif/esp-homekit-sdk/issues/37) reported. Their HomeKit profile, UUIDs and whatnot are present in components/homekit/esp_hap_apple_profiles/, it's just their CIDs are missing in components/homekit/esp_hap_core/.

What? Added the CIDs for Sprinker, Faucet and Shower with enums 28, 29 and 30 respectively in accordance to the Apple HomeKit ADK.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jimmyasyraf commented 1 year ago

@shahpiyushv please review 🤗

shahpiyushv commented 1 year ago

@jimmyasyraf can you just combine the 2 commits into a single commit esp_hap_core: Add CIDs for sprinkler, shower and faucet?

jimmyasyraf commented 1 year ago

@shahpiyushv done!