search

espressif / esp-hosted

Hosted Solution (Linux/MCU) with ESP32 (Wi-Fi + BT + BLE)
Other
706 stars 169 forks source link

esp_hosted_ng: Fix Bluetooth build failure on Linux 6.8.11+ #400

Closed giuliobenetti closed 4 months ago

giuliobenetti commented 5 months ago

After Linux commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=84a4bb6548a29326564f0e659fb8064503ecc1c7 BT_HS has been removed and consequently AMP controllers can't be created, so at this point only HCI_PRIMARY has been left as unique controller type to be created and this became implicit with no need to define if the controller if HCI_PRIMARY or HCI_AMP. So let's assign HCI_PRIMARY up to Linux 6.8.11 only preventing build failure.

mantriyogesh commented 5 months ago

Thank you @giuliobenetti for your time and support. We will pull this ASAP. @kapilkedawat

giuliobenetti commented 5 months ago

@mantriyogesh I've been pointed with a more robust idea in Buildroot ML: https://lore.kernel.org/buildroot/64d16992-68a4-4781-85e5-28338045b526@benettiengineering.com/T/#m162a7fc5cea38b05b73a38694d599e9026125e9b

Please wait until I improve this, so it will cover Linux version < 4.8

giuliobenetti commented 5 months ago

Ah no wait, the check against HCI_BREDR is already there. Anyway it's easier to deal with:

#ifdef HCI_PRIMARY
     hdev->dev_type = HCI_PRIMARY;
#endif

I go with this.

kapilkedawat commented 5 months ago

@Shreyas0-7 please raise internal MR.

mantriyogesh commented 4 months ago

Merged at

https://github.com/espressif/esp-hosted/commit/c74b84fb36b7d9dd04b83411ecadfe05d68f486d

Closing the PR..