espressif / esp-idf-ci-action

GitHub Action for ESP32 CI
MIT License
59 stars 24 forks source link

Use ESP-IDF version from an input #10

Closed kumekay closed 2 years ago

kumekay commented 2 years ago

Use an IDF version from job input,

Because it's not possible to parameterize the docker image with Github Actions YAML syntax, a container with ESP-IDF is launched manually inside a "composite" action

It looks like this way is a bit faster than the current one:

kumekay commented 2 years ago

I didn't add target configuration or a other command support here, but it's trivial to add in the next PRs

kumekay commented 2 years ago

@dobairoland PTAL

tomassebestik commented 2 years ago

@kumekay LGTM Sergei

dobairoland commented 2 years ago

LGTM as far as I can tell.

kumekay commented 2 years ago

@tomassebestik @dobairoland Thank you for your reviews!

jdoubleu commented 2 years ago

I previously got the following error message:

Unexpected input(s) 'esp_idf_version', valid inputs are ['entryPoint', 'args', 'path']

Because I was using the wrong action version, i.e. espressif/esp-idf-ci-action@latest instead of espressif/esp-idf-ci-action@main.

For some reason, the latest version also included the new build process (run docker inside the step manually), which confused me.

kumekay commented 2 years ago

For some reason, the latest version also included the new build process (run docker inside the step manually), which confused me.

espressif/esp-idf-ci-action@latest uses this tag: https://github.com/espressif/esp-idf-ci-action/blob/latest/action.yml has a Docker file and runs in docker, but unlike main it doesn't use docker run shell command but rely on GitHub Actions yml file configuration.