Closed kumekay closed 2 years ago
I didn't add target configuration or a other command support here, but it's trivial to add in the next PRs
@dobairoland PTAL
@kumekay LGTM Sergei
LGTM as far as I can tell.
@tomassebestik @dobairoland Thank you for your reviews!
I previously got the following error message:
Unexpected input(s) 'esp_idf_version', valid inputs are ['entryPoint', 'args', 'path']
Because I was using the wrong action version, i.e. espressif/esp-idf-ci-action@latest
instead of espressif/esp-idf-ci-action@main
.
For some reason, the latest
version also included the new build process (run docker inside the step manually), which confused me.
For some reason, the
latest
version also included the new build process (run docker inside the step manually), which confused me.
espressif/esp-idf-ci-action@latest
uses this tag: https://github.com/espressif/esp-idf-ci-action/blob/latest/action.yml has a Docker file and runs in docker, but unlike main
it doesn't use docker run
shell command but rely on GitHub Actions yml file configuration.
Use an IDF version from job input,
Because it's not possible to parameterize the docker image with Github Actions YAML syntax, a container with ESP-IDF is launched manually inside a "composite" action
It looks like this way is a bit faster than the current one: