search

espressif / esp-idf-provisioning-ios

Apache License 2.0
130 stars 62 forks source link

Properly check security matches when initializing an ESPDevice #16

Closed second-string closed 3 years ago

second-string commented 3 years ago

Fixes this issue

The check for .secure security level for the device to initialize should not be within if-block that is entered if the device advertises a no_sec capability, indicating that there isn't any network security.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

second-string commented 3 years ago

Looks like the build is failing with an Xcode scheme problem. I cannot build the ESPProvisioning library locally since I don't have the correct developer team signing cert access, so I'm not sure how to debug this. From a quick google search it seems like there are some simple fixes, but I'm not too versed in iOS development so I'm not sure what I should be tweaking.

This is the jenkins error: xcodebuild: error: Scheme ESPProvision is not currently configured for the test action.

second-string commented 3 years ago

(didn't mean to close it, sorry!)

vikas-chandra-mnnit commented 3 years ago

Hi @dot4qu, It is a known issue related with CI. We will fix this in our upcoming release. Thanks for giving your time.

shahpiyushv commented 3 years ago

@dot4qu Thanks for your contribution. This has now been merged.