search

espressif / esp-idf-provisioning-ios

Apache License 2.0
130 stars 62 forks source link

Update ESPDevice.swift when applying Wi-Fi Config #72

Open Massmaker opened 10 months ago

Massmaker commented 10 months ago

there is no guarrantee that auto connect to the configured SoftAP will be made by iOS. We face this issue frequently on the current job. My propose is to make check after non-error response to really see if the iPhone/iPad did connect to the required Wi-Fi network. and not to wait until the HTTP request fails in 30 seconds.

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

vikas-chandra-mnnit commented 10 months ago

Hi @Massmaker , Thank you so much for your contribution to our project! We really appreciate the effort you've put into creating the Pull Request. We want to let you know that we will be reviewing and validating the PR. Once the PR passes the validation process and gets approved, we plan to include your changes in the upcoming release.

Thank you once again for your valuable contribution, and please feel free to reach out if you have any questions or need further assistance.

vikas-chandra-mnnit commented 10 months ago

Hi @Massmaker, we have reviewed the PR. The API you have used https://developer.apple.com/documentation/networkextension/nehotspotnetwork/3666511-fetchcurrent is available from iOS 14.0 and SDK support is from iOS 13.0. Can we reuse the verifyConnection(ssid: String) method instead to achieve the same behaviour?