Closed xiahualiu closed 3 weeks ago
Messages | |
---|---|
:book: | 🎉 Good Job! All checks are passing! |
👋 Hello xiahualiu, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
This GitHub project is public mirror of our internal git repository
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.
Generated by :no_entry_sign: dangerJS against 9b01c5a6004d36562abbb5e44990c0a8771023a5
Good point, thank you for the contribution!
This was merged by 248d25a235bc8e92471ec004ba138517bb8613eb. (It will appear in a couple of days) Thank you for the contribution.
This is the new pull request for the already closed PR #13660 due to previous commit issues.
The new commit was created with the
pre-commit
hooks.Besides the original change, there are a few new changes which were introduced by the
pre-commit
hooks, including word spelling, etc.Attached pre-commit log:
Thank you for your time.