fix(esp-modbus): Update slave.c to fix the mode in esp-modbus example (IDFGH-14059)

kabirwbt commented 1 week ago

There is an issue in the lines that I have changed. I think it was copied over from the enum by mistake.

Description

Semi-colon was omitted in the old code and comma as written. I have changed both the offending lines to semi-colon endings.

Testing

Checklist

Before submitting a Pull Request, please ensure the following:

[X] 🚨 This PR does not introduce breaking changes.
[ ] All CI checks (GH Actions) pass.
[ ] Documentation is updated as needed.
[ ] Tests are updated or added as necessary.
[ ] Code is well-commented, especially in complex areas.
[ ] Git history is clean — commits are squashed to the minimum necessary.

github-actions[bot] commented 1 week ago

	Warnings
:warning:	Some issues found for the commit messages in this PR: - the commit message `"Update slave.c to fix the mode"`: - body's lines must not be longer than 100 characters - summary looks empty - type/action looks empty * Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

Warnings

:warning:

**Some issues found for the commit messages in this PR:** - the commit message `"Update slave.c to fix the mode"`: - body's lines must not be longer than 100 characters - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `():

`, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

👋 Hello kabirwbt, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against 8d2a1720640449d7e9b0fec6c1e49cd60ca301ef

kabirwbt commented 1 week ago

@alisitsyn can you please see if this is valid or is my understanding wrong.

espressif / esp-idf