vamshi51
commented
2 years ago Hi @zinke-ct-video, thanks for reporting this. I am able to reproduce this behavior. Error code 262 signifies ESP_ERR_NOT_SUPPORTED. This error is reported from line 520 of the file components/sdmmc/sdmmc_cmd.c
I see there is a bug in, validating the CMD38 argument. SDMMC_MMC_TRIM_ARG and SDMMC_SD_DISCARD_ARG have the same value 1 causing the wrong condition check and resulting in ESP_ERR_NOT_SUPPORTED.
You have rightly figured out, disabling FF_USE_TRIM does not invoke sdmmc_erase_sectors
I assure, that the error message on the serial log output: E (13146) diskio_sdmmc: sdmmc_erase_sectors failed (262) has no adverse effect on the filesystem or the data integrity.
Please help to replace lines 519-525 of components/sdmmc/sdmmc_cmd.c (_sdmmc_erasesectors) with the folowing snippet and share your observation with SanDisk Ultra 32GB Class 10
if (card->is_mmc) {
if ((arg == SDMMC_MMC_TRIM_ARG) && (sdmmc_can_trim(card) != ESP_OK)) {
return ESP_ERR_NOT_SUPPORTED;
}
if ((arg == SDMMC_MMC_DISCARD_ARG) && (sdmmc_can_discard(card) != ESP_OK)) {
return ESP_ERR_NOT_SUPPORTED;
}
} else {
if ((arg == SDMMC_SD_DISCARD_ARG) && (sdmmc_can_discard(card) != ESP_OK)) {
return ESP_ERR_NOT_SUPPORTED;
}
}@igrr , I see we can replace the line-80 of components/fatfs/diskio/diskio_sdmmc.c (information instead of errror to avoid panic)
ESP_LOGE(TAG, "sdmmc_erase_sectors failed (%d)", err);
as
ESP_LOGI(TAG, "sdmmc_erase_sectors returned (%d)", err);
zinke-ct-video
Vincenzo1992
Environment
Problem Description
TL;DR
File write operations on SD cards having DISCARD or FULE support fail. This bug was introduced with the commits 964592 and ffdbee
In-depth explanation
My ESP32 is connected to an SD card. The ESP32 performs lots of read and write operations on files on the SD card. Before the commits mentioned above came in, everything was fine. After these commits came in, I noticed that on some types of SD cards errors occur during file write operations. The following error message appears on the serial log output for every failed operation:
E (13146) diskio_sdmmc: sdmmc_erase_sectors failed (262)I further investigated the bug and found that this error occurs only on some types of SD cards. To find the difference between the cards I wrote the following code to dump the SD card registers:
I tested two types of SD cards, the SanDisk Ultra doesn't work, the Samsung EVO works fine. Here the is the log output for both cards:
SanDisk Ultra 32GB Class 10:
Samsung EVO 32GB:
As you can see, the only significant differences are card->ssr.discard_support and card->ssr.fule_support.
Next, I have checked if I can make the error disappear if I disable these flags on the SanDisk Ultra card manually. To do so, I added the following two lines.
Doing so the SanDisk Ultra card with discard and fule support works fine now, too.
The last test I did was disabling TRIM support in the fatfs component. So let's go back and remove the above workaround that disabled discard_support and fule_support. Then go to the file esp-idf/components/fatfs/src/ffconf.h and change the line 238 from
#define FF_USE_TRIM 1to#define FF_USE_TRIM 0. Also this step makes the error disappear and both cards work fine.So I conclude that there must be an issue with the newly introduced function
sdmmc_erase_sectorsin the file esp-idf/components/fatfs/diskio/diskio_sdmmc.cExpected Behavior
All file I/O should succeed even with cards that support DISCARD and FULE.