search

espressif / esp-insights

ESP Insights: A remote diagnostics/observability framework for connected devices
Apache License 2.0
101 stars 27 forks source link

Correct archive filename (fix #9) #10

Open jcassette opened 2 years ago

jcassette commented 2 years ago

Fix #9

vikramdattu commented 2 years ago

@jcassette thanks for spotting and fixing this. We will review it internally and take the change.

vikramdattu commented 2 years ago

Hi @jcassette, if you set PROJECT_VER in your top level CMakeList.txt, that is picked up and you won't fall to git describe path which you are. We recommend you setting PROJECT_VER in project CMakeList.txt.

Example: https://github.com/espressif/esp-insights/blob/1d6bb172ef5308073f59260c1ed25078f33521f3/examples/minimal_diagnostics/CMakeLists.txt#L14