search

espressif / esp-insights

ESP Insights: A remote diagnostics/observability framework for connected devices
Apache License 2.0
101 stars 27 forks source link

Breaking backwards compatible change `log_printfv` #23

Open softwaregravy opened 1 year ago

softwaregravy commented 1 year ago

This change breaks trying to link to older versions of arduino-esp32. This method was added in this change.

However, esp-insights is not versioned. So now it is not possible to build the release tagged 2.0.5 of arduino-esp32 using esp32-arduino-lib-builder. This fails on linking log_printfv.

Is there any way to know the versions (I.e. head commit hash) of this library when the v2.0.5 version of arduino-esp32 was generated?

I'm not really sure the correct way to map this across all projects. I am trying to make a 1-line change to arduino-esp32 at the version I am currently using without changing versions and risking further breaks.

sanketwadekar commented 1 year ago

If you don't want to use esp-insights in arduino, you can remove it from the cmakelists.txt file here. Can you try and let me know if this solves the linking issue?