search

espressif / esp-insights

ESP Insights: A remote diagnostics/observability framework for connected devices
Apache License 2.0
101 stars 27 forks source link

Implementing esp_insights_unregister_periodic_handler. #8

Closed tmedicci closed 2 years ago

tmedicci commented 2 years ago

In order to properly deinitialize the ESP Insights it is necessary to stop the periodic handler timer, stop the work queue and deinit it too. Finally the esp_insights_entry_t structure is freed.

Please note that that it was necessary to add a modification for the rmaker_common component (submodule) that is being reviewd at https://github.com/espressif/esp-rainmaker-common/pull/2

vikramdattu commented 2 years ago

@tmedicci few comments. LGTM otherwise.

tmedicci commented 2 years ago

Also, please rebase the branch to latest master.

Done!

vikramdattu commented 2 years ago

The change is merged via internal PR. This PR can be closed.

tmedicci commented 2 years ago

The change is merged via internal PR. This PR can be closed.

Done!