espressif / esp-iot-solution

Espressif IoT Library. IoT Device Drivers, Documentations And Solutions.
Apache License 2.0
1.9k stars 760 forks source link

fix(led_indicator): no need Button there (AEGHB-528) #328

Closed diplfranzhoepfinger closed 8 months ago

diplfranzhoepfinger commented 8 months ago

no need Button there

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 8 months ago
Warnings
:warning: The Pull Request description looks very brief, please check if more details can be added.

👋 Hello diplfranzhoepfinger, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 875a6d83d585410eb5c0e2b6de78902fb074253a

leeebo commented 8 months ago

@diplfranzhoepfinger Thanks for your contribution, will merge it