Closed leeebo closed 2 weeks ago
Messages | |
---|---|
:book: | 🎉 Good Job! All checks are passing! |
👋 Hello leeebo, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 45a952d0418d0834062adf274bffbfa37ddafb47
sha=ebcc082a97b0a06aa07ee5893f9c1fb6ab56cd8e
sha=45a952d0418d0834062adf274bffbfa37ddafb47
the github action should be fixed in https://github.com/espressif/sync-pr-to-gitlab/pull/6
sha=45a952d0418d0834062adf274bffbfa37ddafb47
Related https://github.com/espressif/esp-iot-solution/issues/360