search

espressif / esp-lwip

Fork of lwIP (https://savannah.nongnu.org/projects/lwip/) with ESP-IDF specific patches
Other
79 stars 126 forks source link

Document that sntp_setservername doesn't copy the string (IDFGH-5714) #33

Closed dfries closed 2 years ago

dfries commented 2 years ago

I was expecting the string to be duplicate, doing a Google search shows others did as well.

david-cermak commented 2 years ago

@dfries Thanks for the PR. I would prefer we post the contribution to lwip upstream first before accepting here, but since it's a minor docs update, and helpful, it LGTM.

david-cermak commented 2 years ago

Cherry-picked as 54acdb598ec3bcb9e476d779e5240adb783b8da3

Thanks for the contribution!