search

espressif / esp-lwip

Fork of lwIP (https://savannah.nongnu.org/projects/lwip/) with ESP-IDF specific patches
Other
79 stars 126 forks source link

Upstream changes/patches please (IDFGH-6818) #41

Closed vulptex closed 2 years ago

vulptex commented 2 years ago

Please upstream generic patches to lwip please.

There are various patches more people can profit from, for me personally it is:

Why does this fork exist?

vulptex commented 2 years ago

I already started "moving" your changes ;-)

https://github.com/lwip-tcpip/lwip/pull/10

david-cermak commented 2 years ago

Hi @vulptex

We plan to upstream the changes where applicable. Some of the patches need some rework, others could be simply moved to esp port layers. We're working on that and the plan is to consolidate and clean-up the patches in 2.1.3-esp (to be added from IDF v5.0)

Why does this fork exist?

Good question, ideally it shouldn't exist after the cleanup, but some changes may still not be applicable, not generic enough to be accepted to upstream (e.g. on-demand timers). I've created this draft document listing all the esp-patches: https://github.com/espressif/esp-lwip/wiki/Espressif-patches-in-2.1.2-esp-on-top-of-2.1.2-rel and will keep it updated with the actual status and links if upstreamed/accepted.

I already started "moving" your changes ;-) https://github.com/lwip-tcpip/lwip/pull/10

Oh, thanks, didn't know they accept GitHub PRs, too. I've always posted patches via https://savannah.nongnu.org/patch/?group=lwip. Also, I think would be nice to keep the original commit author when "moving" *your* changes ;-)

vulptex commented 2 years ago

i closed the PR @ lwip..will re-open when i have more time to play the "PR review" game ;-)