Closed jonsmirl closed 2 months ago
@jonsmirl you need to generate factory partition using mfg_tool.py with --calendar-types and --locales arguments to specify allowed values for supported calender types and locales only then it can write successfully if the values are among supported calendar types and locales respectively. You can follow the instructions here
You also need to set Device_info_provider to factory in order to read the values from factory partition. You can see here
time_format_localization::create(root, &tfl_config, CLUSTER_FLAG_SERVER, NULL);
Change the NULL to 1 as it is used as a bitmap for enabling calender_format feature.
I didn't want to turn the calendar types feature on. I only want 12/24hr clock.
This localization cluster design doesn't work when you OTA in different images for different languages. What if we add translated images after the device ships? The list of available locales should be writable to allow a new OTA image to change it.
Of course I can still do that by messing with the nvs flash.
That print comes up when initializing the cluster, the cluster init method also try to touch the active-calendar-type and supported-calendar-types attributes even if calendar format feature is not enabled. Fixing that in https://github.com/project-chip/connectedhomeip/pull/32850.
Also, hour-format and active-calendar-type attributes are not supposed to be nullable, will fix that as well.
That print comes up when initializing the cluster, the cluster init method also try to touch the active-calendar-type and supported-calendar-types attributes even if calendar format feature is not enabled. Fixing that in https://github.com/project-chip/connectedhomeip/pull/32850.
Fixed in https://github.com/project-chip/connectedhomeip/pull/32747
Looks like the fix is not yet synced to esp-matter connectedhomeip submodule. Will re-open, until this is confirmed
Closing as the fix is now synced
produces these errors
Hour format does not appear to be stored in flash.