Timer ISR dispatch mode configuration error (IDFGH-11059)

espressif / esp-modbus

ESP-Modbus - the officially suppported library for Modbus protocol (serial RS485 + TCP over WiFi or Ethernet).

Apache License 2.0

117 stars 55 forks source link

Timer ISR dispatch mode configuration error (IDFGH-11059) #37

Closed allard-potma closed 1 year ago

allard-potma commented 1 year ago

Hi, I noticed a small error in the timer isr dispatch mode configuration: The kconfig file names the configuration option CONFIG_FMB_TIMER_USE_ISR_DISPATCH_METHOD In esp-modbus/freemodbus/modbus/include/mbconfig.h

The define is renamed, but with the wrong name: CONFIG_FMB_TIMER_ISR_IN_IRAM This results in a timer ISR that is not placed into IRAM.

alisitsyn commented 1 year ago

Hi,

Ah, it seems the commits were squashed incorrectly. The issue is confirmed and will be fixed in coming release. Thanks you.

alisitsyn commented 1 year ago

Merged in release v1.0.12, commit ea3f06cf2b56ec3839d76cf9844f46602b536223