espressif / esp-modbus

ESP-Modbus - the officially suppported library for Modbus protocol (serial RS485 + TCP over WiFi or Ethernet).
Apache License 2.0
107 stars 49 forks source link

change(modbus): Update modbus task affinity config type (IDFGH-11388) #41

Closed Dazza0 closed 11 months ago

Dazza0 commented 11 months ago

ESP-IDF updates the task affinity config option from hex to int, and provides constant values for each affinity value. This commit syncs FMB_PORT_TASK_AFFINITY with those changes.

See internal MR !26701 for more details.

CLAassistant commented 11 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Dazza0 commented 11 months ago

@alisitsyn Do we need to bump the bugfix version of the modbus component for every bugfix?

alisitsyn commented 11 months ago

@alisitsyn Do we need to bump the bugfix version of the modbus component for every bugfix?

No, the version is updated manually for every new scheduled component release.

The esp-modbus component should be able to be compiled with all versions of esp-idf. I propose to add the check if FREERTOS_COREX_AFFINITY, CONFIG_FREERTOS_NO_AFFINITY are defined for compatibility with previous versions of esp-idf.

Dazza0 commented 11 months ago

@alisitsyn Sorry, looks like there's not a good way to introduce this change to the managed components in a non-breaking manner. I'll closing this PR (and associated MR) and will delay this change until ESP-IDF v6.0.

alisitsyn commented 11 months ago

@Dazza0 , Thank you for update. I don't see a good solution for this issue as well and would agree with you to postpone this change.