espressif / esp-modbus

ESP-Modbus - the officially suppported library for Modbus protocol (serial RS485 + TCP over WiFi or Ethernet).
Apache License 2.0
100 stars 48 forks source link

Add core affinity setting for tcp_slave (IDFGH-7653) #7

Closed allard-potma closed 2 years ago

allard-potma commented 2 years ago

Earlier I requested core affinity to be put in this component: [https://github.com/espressif/esp-idf/issues/6700](ESP-IDF #6700). I seems that the task "tcp_server_task" in port_tcp_slave.c is missed, it still uses xTaskCreate instead of xTaskCreatePinnedToCore.

alisitsyn commented 2 years ago

@allard-potma ,

Thank you for this finding. At some stage the change you described disappeared. It will be fixed soon.

alisitsyn commented 2 years ago

The fix is planned to be implemented in ver v1.0.4 of the component.

alisitsyn commented 2 years ago

Fixed with the commit: 28ebfb1712a5b35cff80545009b1abab925a670d