espressif / esp-nimble

A fork of NimBLE stack, for use with ESP32 and ESP-IDF
Apache License 2.0
76 stars 50 forks source link

fix #11 closing bracket conditional for c++ #12

Closed marcogmaia closed 4 years ago

marcogmaia commented 4 years ago

fix ble_hs_pvcy.h c++ closing bracket.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

prasad-alatkar commented 4 years ago

@marcogmaia Thank you for fix. LGTM

prasad-alatkar commented 4 years ago

Hi @marcogmaia Could you please also add header guards at the start of the file ?

#ifndef H_BLE_HS_PVCY_
#define H_BLE_HS_PVCY_

Of course, corresponding #endif at the end as well ?

marcogmaia commented 4 years ago

sure, when I get home I'll do it

marcogmaia commented 4 years ago

@prasad-alatkar All done. :)

prasad-alatkar commented 4 years ago

LGTM. @dhrishi PTAL

dhrishi commented 4 years ago

@marcogmaia Thanks for the PR. This looks good!

marcogmaia commented 4 years ago

sry for closing/reopenning, I clicked "close" in the app thinking it would close the dialog