espressif / esp-nimble

A fork of NimBLE stack, for use with ESP32 and ESP-IDF

Apache License 2.0

76 stars 50 forks source link

Correct #define BT_MESH_ELEM ordering and element #2

Closed technosf closed 4 years ago

technosf commented 4 years ago

define BT_MESH_ELEM expands leaving out .addr element and not in order causing errors in c++ builds.

Adding place holder for .addr and updating to correct order

dhrishi commented 4 years ago

Hi @technosf Thanks for the PR. This being a fix in the NimBLE host stack (and not the porting layer), we would encourage you to raise a PR to the upstream repository https://github.com/apache/mynewt-nimble.

You can keep this PR open till that time. I will merge it when it gets absorbed upstream.

dhrishi commented 4 years ago

Hi @technosf Did you get a chance to raise an upstream PR?

technosf commented 4 years ago

I didn't - I need to go research this and spend some time in the Apache forums, which I havent had time for.

I'll close this ticket for that reason.