search

espressif / esp-nimble

A fork of NimBLE stack, for use with ESP32 and ESP-IDF
Apache License 2.0
76 stars 50 forks source link

Prevent CCCD data from being stored when not bonded. #9

Closed h2zero closed 4 years ago

h2zero commented 4 years ago

The issue this addresses occurs when a master pairs with the device but one of the devices does not permit bonding. In this situation, as a slave, we will store the CCCD data anyway, but should not. This patch corrects that.

https://github.com/apache/mynewt-nimble/issues/788

dhrishi commented 4 years ago

Hi @h2zero Thanks for your contribution. I see that you have also raised a PR in the upstream repository. Can you please close this one. We will integrate the upstream PR in esp-nimble once it is approved and merged. That's the policy we follow for the changes in the common code (not specific to Espressif)

h2zero commented 4 years ago

Ok, I made this one here because it includes #730 which is required for the upstream PR I made to work in this fork, wasn't sure if you were going to apply that one or not so I brought it up here.

dhrishi commented 4 years ago

@h2zero Thanks for the clarification. We will check the corresponding PR as well and include it as appropriate cc @prasad-alatkar

h2zero commented 4 years ago

@dhrishi Sorry about that, was meant more as an informational PR, was tired and didn't describe it properly.