search

espressif / esp-now

A connectionless Wi-Fi communication protocol
Apache License 2.0
477 stars 90 forks source link

Espnow control bugs (AEGHB-320) #84

Closed n3b0j5a closed 5 months ago

n3b0j5a commented 11 months ago

@lhespress I found two more bugs in control source. First, bindlist in not properly loaded upon startup. It is only loaded if I call espnow_ctrl_responder_bind which is what i do not want to do every time, it should be loaded from flash. Second one, if i call espnow_ctrl_responder_data and register callback, and after that i call espnow_ctrl_responder_bind things can get messy because callback functions are inside of bindlist structure. I addressed bot problems in PR #83 by removing callback data from bindlist and making sure that bindlist is loaded from flash before use.

lhespress commented 11 months ago

@n3b0j5a Thanks for your contribution. I submitted some reviews, PTAL.

n3b0j5a commented 11 months ago

@lhespress I see no review there?

lhespress commented 11 months ago

@n3b0j5a I started a review for espnow_load_bindlist API.

n3b0j5a commented 10 months ago

@lhespress For some reason I cannot see it. Actually i don't see any comments on that PR

lhespress commented 10 months ago

@n3b0j5a sorry, i forget to change the review state, you can see it now.

lhespress commented 5 months ago

@n3b0j5a I have merged it to the master branch.