New component `esp_wifi_remote`

espressif / esp-protocols

Collection of ESP-IDF components related to networking protocols

165 stars 115 forks source link

New component `esp_wifi_remote` #516

Closed david-cermak closed 3 months ago

david-cermak commented 4 months ago

Initial version

TODO

This version

[x] Add README and docs
[x] Cleanup git history
[x] new component stuff (changelog, versions)

Next versions

Add APIs from esp_wifi_he.h
Add cross-check that slave and host wifi config matches
Add coexistence of the wifi_remote and wifi_native configurations

CLAassistant commented 4 months ago

All committers have signed the CLA.

mantriyogesh commented 3 months ago

Hello @david-cermak ,

I had reviewed the changes, looks fine. But let me test these and confirm. Some small code changes I had to do while running, which I will attach as patch here..

david-cermak commented 3 months ago

Hi guys, I've addressed most of the comments, could you please take another look and check mainly the unresolved discussions if it's okay with you? I likely won't be able to resolve it correctly with the initial version, though.

mantriyogesh commented 3 months ago

hosted_hooked_with_esp_wifi_remote.patch

david-cermak commented 3 months ago

hosted_hooked_with_esp_wifi_remote.patch

Thanks for sharing the patch. I've updated the PR accordingly and simplified the component a little:

removed esp_wifi_remote_slave_init() altogether while making the channel operations public -- helps esp_hosted to implement it based on public channels
defined most of the channel operations WEAK, so esp_hosted can update them
made the minor modification and updates (logs, nullptr checks)

david-cermak commented 3 months ago

Thanks @euripedesrocha for the review. I'm taking the liberty of merging this now, I'll address the outstanding comments in the upcoming version. Thanks everyone for having a look!