search

espressif / esp-protocols

Collection of ESP-IDF components related to networking protocols
181 stars 126 forks source link

fix(websocket): fix esp_event dependency management (IDFGH-12301) (IDFGH-12302) #523

Closed bryghtlabs-richard closed 6 months ago

bryghtlabs-richard commented 6 months ago

Move esp_event from PRIV_REQUIRES to REQUIRES, as it is included by esp_websocket_client.h, so any code including that header also requires esp_event.

This resolves the following build error for files not explicitly requiring esp_event:

ninja: build stopped: subcommand failed. Compilation failed because esp_websocket_client.h (in "espressifesp_websocket_client" component) includes esp_event.h, provided by esp_event component(s). However, esp_event component(s) is in the private requirements list of "espressif__esp_websocket_client". To fix this, move esp_event from PRIV_REQUIRES into REQUIRES list of idf_component_register call in ...\managed_components\espressifesp_websocket_client\CMakeLists.txt. ninja failed with exit code 1, output of the command is in...

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.