search

espressif / esp-protocols

Collection of ESP-IDF components related to networking protocols
165 stars 115 forks source link

feat(websocket_client): Add option to set and use cert_common_name in Websocket client (IDFGH-12926) #583

Open DCSBL opened 1 month ago

DCSBL commented 1 month ago

Set a common name that is verified. We use this via a server using a custom certificate bundle + common name combo.

I am not really sure if we need to deny when skip_common_name && cert_common_name is set.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

gabsuren commented 3 days ago

@DCSBL Thank you for your contribution. However, the changes are causing compilation issues in our CI pipeline. Please refer to the details here: https://github.com/espressif/esp-protocols/actions/runs/9318507655/job/26646687075?pr=583

DCSBL commented 2 days ago

Hi @gabsuren, I think I've resolved the issues found by the workflow. Maybe it now detects some other issues but let's see.

I've added a check for the version as setting common name is only available since esp-idf 5.1 (https://github.com/espressif/esp-idf/commit/ce321837497bb701d22d3aaf3fcd8e26e310d21f). I am not sure if this is the way to go, we could also bumb the minimal required version but that seems a bit aggressive to me.