espressif / esp-protocols

Collection of ESP-IDF components related to networking protocols
181 stars 126 forks source link

feat(wifi_remote): Make wifi_remote depend on esp_hosted (IDFGH-13027) #596

Closed SohKamYung-Espressif closed 3 months ago

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

david-cermak commented 3 months ago

@SohKamYung-Espressif Thanks for the contribution, pipeline has passed and I'm about to merge it. but before doing so, I'd like to ask you to just check it locally that it still works (removing the project's dependency on esp_hosted and rely only on the transient one from esp_wifi_remote). My only concern is about the __weak attribute of the WiFi definitions in wifi_remote, since it also depends on linking order of static libs and this PR alters it.

SohKamYung-Espressif commented 3 months ago

@david-cermak Sure. Which project(s) should I test this change on (locally adding the dependency on esp_hosted into esp_wifi_remote component AND removing the dependency on esp_hosted in the project's idf_component.yml)?

I have tested this with my S3 <---> C6 SDIO test board (native wifi on S3 disabled) with the iperf example project and it builds and runs as expected.

david-cermak commented 3 months ago

Thanks for testing!